Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] JSConfig: Add multiViewEnabled value. #47939

Merged
merged 3 commits into from
Nov 15, 2023
Merged

[web] JSConfig: Add multiViewEnabled value. #47939

merged 3 commits into from
Nov 15, 2023

Conversation

ditman
Copy link
Member

@ditman ditman commented Nov 11, 2023 •
edited
Loading

This change:

  • Adds a boolean to multiViewEnabled (defaults to false).
  • Removes unused canvasKitMaximumSurfaces value.

Part of: flutter/flutter#137377

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Nov 11, 2023
harryterkelsen
harryterkelsen approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdebbar
mdebbar approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

lib/web_ui/lib/src/engine/configuration.dart
/// Multi-view mode allows apps to:
///
/// * Start without a `hostElement`.
/// * Add/remove views (`hostElements`) from JS while the application is running.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ditman
Copy link
Member Author

ditman commented Nov 14, 2023

Did I really break a pointer test with this? Odd. I'm going to rebase and see what CI thinks about my branch :/

ditman
ditman commented Nov 14, 2023
View reviewed changes
lib/web_ui/lib/src/engine/configuration.dart
@JS('debugShowSemanticsNodes')
external JSBoolean? get _debugShowSemanticsNodes;
bool? get debugShowSemanticsNodes => _debugShowSemanticsNodes?.toDart;

external DomElement? get hostElement;

@JS('multiViewEnabled')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can give any "external" (JS) name we want to this property, like "multiViewEnabledExperimental" or something scary like that. Do we need that, or do we just call it "multiViewEnabled"? @mdebbar?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to keep the name multiViewEnabled to avoid a little bit of churn down the line. Anyone who makes use of this flag ought to know that this is experimental and could break at any time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with this!

@ditman
Copy link
Member Author

ditman commented Nov 14, 2023

I'll land this after @eyebrowsoffire "flutter.js in tests" PR lands, to not cause any conflicts on this end.

@ditman
Copy link
Member Author

ditman commented Nov 15, 2023

Rebased and ready to land, applying autosubmit!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 15, 2023
@ditman ditman changed the title [web] Config: + multiViewEnabled. - canvasKitMaximumSurfaces. [web] JSConfig: Add multiViewEnabled value. Nov 15, 2023
@auto-submit auto-submit bot merged commit bc5bbd3 into flutter:main Nov 15, 2023
24 checks passed
@ditman ditman deleted the add-multiview-toggle branch November 15, 2023 02:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
bc5bbd3b9 [web] JSConfig: Add multiViewEnabled value. (flutter/engine…
b9b29fb 
…#47939)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (#…
cfdc6c5 
…138457)

flutter/engine@d7ca057...bc5bbd3

2023-11-15 [email protected] [web] JSConfig: Add multiViewEnabled value. (flutter/engine#47939)
2023-11-15 [email protected] [Impeller] Simplify convex tessellation (flutter/engine#47957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

@mdebbar mdebbar mdebbar approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ditman @mdebbar @harryterkelsen